Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NewAppLayoutEnabled Feature Flag #6584

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Jul 18, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds new_app_layout_enabled Feature Flag

Motivation and context

Closes #6578

We will use this feature flag to hide changes related to the Space Switching and Edit Layout projects until they are both ready to be released together

The flag can be found in debug menu > private settings

Screenshots / GIFs

Tests

  • Go to the debug menu (either inside hamburger menu or first screen on auth flow)
  • Go to features
  • Enable feature flag
  • Restart app and see feature flag is still enabled

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini marked this pull request as ready for review July 18, 2022 14:58
@ericdecanini ericdecanini requested review from fedrunov and a team July 18, 2022 14:58
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case you should rather add a new VectorFeatures, rather than a new VectorOverrides. VectorOverrides should probably be removed, everything could be VectorFeatures. It does not block this PR to be merge though.
Let's discuss this with @ouchadam later.

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ericdecanini ericdecanini merged commit 221cb24 into develop Jul 19, 2022
@ericdecanini ericdecanini deleted the task/eric/new_layout_feature_flag branch July 19, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NewLayout Feature Flag for Space Switching and Edit Layout
3 participants