Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just go back to the timeline if the user is already viewing the DM with the other user. #6549

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 13, 2022

Fix #6514

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Before After
DirectMessageBefore DirectMessage

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from mnaturel July 13, 2022 20:47
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@@ -17,6 +17,7 @@
package im.vector.app.features.home.room.detail

sealed class RoomDetailPendingAction {
object DoNothing : RoomDetailPendingAction()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just wondering if this action is really needed since we will do nothing when receiving it? Does it work without any declared action?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see thanks for explaining.

Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one question about the need of the DoNothing action.

@bmarty bmarty merged commit cdbc197 into develop Jul 18, 2022
@bmarty bmarty deleted the feature/bma/fix_6514 branch July 18, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants