Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Location Share] - Standardise "Stop" texts for live #6541

Closed
mnaturel opened this issue Jul 13, 2022 · 0 comments · Fixed by #6542
Closed

[Location Share] - Standardise "Stop" texts for live #6541

mnaturel opened this issue Jul 13, 2022 · 0 comments · Fixed by #6542
Assignees
@mnaturel
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@mnaturel
Copy link
Contributor

Your use case

What would you like to do?

Use the same text for stop button everywhere.
Fix insets problem on some languages.

Why would you like to do it?

To be consistent and to have nicer UI.

How would you like to achieve it?

Use the same string key.
Fix the button styles.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 13, 2022
@mnaturel mnaturel self-assigned this Jul 13, 2022
@mnaturel mnaturel mentioned this issue Jul 13, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Location Share] - Standardise "Stop" texts for live (PSG-622) element-hq/element-android
1 participant
@mnaturel