Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More DB migration log #6538

Merged
merged 3 commits into from
Jul 18, 2022
Merged

More DB migration log #6538

merged 3 commits into from
Jul 18, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 13, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Log the duration of the DB migrations.

Motivation and context

Just have more info on the logs and the rageshakes.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

override fun migrate(realm: DynamicRealm, oldVersion: Long, newVersion: Long) {
Timber.d("Migrating Auth Realm from $oldVersion to $newVersion")

override fun doMigrate(realm: DynamicRealm, oldVersion: Long) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newVersion is never used, also I think it will be always equal to schemaVersion if it is necessary.

@bmarty bmarty requested review from a team and Claire1817 and removed request for a team July 13, 2022 12:55
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Claire1817 Claire1817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bmarty bmarty force-pushed the feature/bma/more_migration_log branch from 04e6df2 to 428942d Compare July 18, 2022 15:23
@bmarty bmarty merged commit b0237a4 into develop Jul 18, 2022
@bmarty bmarty deleted the feature/bma/more_migration_log branch July 18, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants