Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Epoxy layout annotation references #6389

Closed
ouchadam opened this issue Jun 28, 2022 · 0 comments · Fixed by #6415
Closed

Replace Epoxy layout annotation references #6389

ouchadam opened this issue Jun 28, 2022 · 0 comments · Fixed by #6415
Assignees
@ouchadam
Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Modularization

Comments

@ouchadam
Copy link
Contributor

AGP 8 is planning to make R references non final which will cause our epoxy items to become non-compiling due to their usage of a layout reference in the class annotation, this is also a problem for libraries.

We can avoid this by switching to override fun getDefaultLayoutId(): Int
@ouchadam ouchadam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-DevX Anything that can improve the DevX labels Jun 28, 2022
@ouchadam ouchadam self-assigned this Jun 29, 2022
@ouchadam ouchadam mentioned this issue Jun 29, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-DevX Anything that can improve the DevX T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing epoxy item annotation layout references with getDefaultLayoutId element-hq/element-android
1 participant
@ouchadam