Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce query on state event #6319

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Enforce query on state event #6319

merged 3 commits into from
Jun 16, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 15, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure we do not use QueryStringValue.NoCondition or QueryStringValue.IsNull to query for State Event.

Also remove default value for those parameters.

Motivation and context

Some UI may be incorrect if invalid state Event are sent to a room. We were using NoCondition to query State Event, rather than IsEmpty.

Screenshots / GIFs

Tests

  • Some smoke test on real device, and run the sanity test on the emulator.

image

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

…lue.IsNull` to query for State Event.

Also remove default value for those parameters.
@bmarty bmarty changed the title Ensure we do not use QueryStringValue.NoCondition or `QueryStringVa… Enforce query on state event Jun 15, 2022
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@bmarty bmarty marked this pull request as ready for review June 16, 2022 13:05
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit 8238cd7 into develop Jun 16, 2022
@bmarty bmarty deleted the feature/bma/stateEventQuery branch June 16, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants