Setup Flipper #6300
Setup Flipper #6300
Conversation
bmarty
force-pushed
the
feature/bma/flipper
branch
2 times, most recently
from
5264a4f
to
7877d7c
Compare
| /** | ||
| * Prints out info on DB size to logcat. | ||
| */ | ||
| fun logDbUsageInfo() |
There was a problem hiding this comment.
Note: it should probably return a String rather than printing things on logcat, but this is out of scope of this PR.
bmarty
force-pushed
the
feature/bma/flipper
branch
from
7877d7c
to
c151902
Compare
|
exodus is not happy. We should run exodus on the release version. Will see what we can do. |
| /** | ||
| * List of network interceptors, they will be added when building an OkHttp client. | ||
| */ | ||
| val networkInterceptors: List<Interceptor> = emptyList(), |
There was a problem hiding this comment.
I'd instead allow to provide an okhttp client. We'll be able to use okhttpClient.newBuilder().
If the app is using his own okhttp it'll allow to share resources.
There was a problem hiding this comment.
See my latest commit 5c84fdc, the interceptors provided by the configuration have to be added at the end, to ensure to see all the request headers.
Providing on OkHttp client make sense though, maybe for another dedicated PR?
| /** | ||
| * Get all the available Realm Configuration. | ||
| */ | ||
| fun getAllRealmConfigurations(): List<RealmConfiguration> |
There was a problem hiding this comment.
Maybe we could instead returns a list of flipper plugin?
There was a problem hiding this comment.
The Matrix SDK does not know what a Flipper plugin is, only the debug version of module vector knows it. Also there is only one Plugin to set up for all the RealmDatabase inspection.
Move getLastSession() to the SessionManager Create `DebugService` Move `logDbUsageInfo()` to `DebugService`
…ensure to view all the network request headers in Flipper.
bmarty
force-pushed
the
feature/bma/flipper
branch
from
91c0e2c
to
0abeb33
Compare
|
Rebased, exodus from GH action should be fine, exodus from Buildkite is still supposed to fail. |
|
SonarCloud Quality Gate failed. |
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class FlipperProxy @Inject constructor( |
There was a problem hiding this comment.
💯 for only including in the debug sourceset
Type of change
Content
DebugServiceon the SDK to get access to theRealmconfigurationslogDbUsageInfo()toDebugServiceWhat will be done later:
Motivation and context
Help developer to develop the app, especially by inspecting the databases content.
Closes #6305
Screenshots / GIFs
Network
Database
LayoutInspector
On phone Diagnostic Activity
Tests
Tested devices
Checklist