Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flickering bottom bar of live location item [PSF-1057] #6264

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Fix flickering bottom bar of live location item [PSF-1057] #6264

merged 2 commits into from
Jun 13, 2022

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Jun 8, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • While rendering live location in timeline, the bottom part of the view was flickering on every location changes.

Motivation and context

  • Glide clears the current image while loading the new image. We can prevent this by settings old image as placeholder.

Screenshots / GIFs

Before:

flickering_before.mp4

After:

flickering_after.mp4

Tests

  • Select location attachment from composer menu
  • Select "share live location"
  • Watch the timeline item when the location is updated

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@onurays onurays requested review from a team, yostyle and mnaturel and removed request for a team June 8, 2022 13:08
@onurays onurays changed the title Fix flickering bottom bar of live location item Fix flickering bottom bar of live location item [PSF-1057] Jun 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

mnaturel
mnaturel approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

@onurays onurays requested review from a team and ganfra and removed request for yostyle and a team June 10, 2022 10:46
ganfra
ganfra approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onurays onurays merged commit 2fbbee2 into develop Jun 13, 2022
@onurays onurays deleted the feature/ons/fix_flickering_location_bottom_bar branch June 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaturel mnaturel mnaturel approved these changes

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onurays @ganfra @mnaturel