Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room now exposes methods to get the various Services #5858

Merged
merged 5 commits into from
May 4, 2022
Merged

Room now exposes methods to get the various Services #5858

merged 5 commits into from
May 4, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 28, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Same than #5816 but for Room

Motivation and context

Same than #5816.

2 extensions (shortcut) created:

  • Room.getTimelineEvent(...)
  • Room.getStateEvent(...)

Screenshots / GIFs

Tests

Smoke test and sanity test: OK with commenting ignore user part (broken for other reason)

image

Tested devices

  • Physical
  • Emulator
  • OS version(s):

@bmarty bmarty requested review from a team, ariskotsomitopoulos and fedrunov and removed request for a team April 28, 2022 08:26
@bmarty bmarty marked this pull request as ready for review April 28, 2022 08:26
@github-actions
Copy link

github-actions bot commented Apr 28, 2022 •
edited
Loading

Unit Test Results

118 files  +4  118 suites  +4   1m 30s ⏱️ +11s
203 tests +1  203 ✔️ +1  0 💤 ±0  0 ❌ ±0 
682 runs  +4  682 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 3bcfd7c. ± Comparison against base commit 3d190bb.

♻️ This comment has been updated with latest results.

@bmarty bmarty mentioned this pull request Apr 28, 2022
Open
6 tasks
ariskotsomitopoulos
ariskotsomitopoulos approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large but straightforward PR. It encapsulates much better the usages of the services! I didn't observe any issue 👍

@bmarty bmarty merged commit 5076b2c into develop May 4, 2022
@bmarty bmarty deleted the feature/bma/room_api branch May 4, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariskotsomitopoulos ariskotsomitopoulos ariskotsomitopoulos approved these changes

@fedrunov fedrunov Awaiting requested review from fedrunov fedrunov was automatically assigned from element-hq/element-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @ariskotsomitopoulos