Changes destination when joining space to explore space rooms #5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdecanini
requested review from
a team and
ouchadam
and removed request for
a team
ouchadam
reviewed
Apr 14, 2022
| @@ -176,6 +176,9 @@ class DefaultNavigator @Inject constructor( | |||
| Navigator.PostSwitchSpaceAction.OpenAddExistingRooms -> { | |||
| startActivity(context, SpaceManageActivity.newIntent(context, spaceId, ManageType.AddRooms), false) | |||
| } | |||
| Navigator.PostSwitchSpaceAction.OpenRoomList -> { | |||
| startActivity(context, SpaceExploreActivity.newIntent(context, spaceId), false) | |||
There was a problem hiding this comment.
would be handy to have a named parameter for the false argument
There was a problem hiding this comment.
I agree it's better to use named argument for Boolean parameters, as a global rule 💯
ouchadam
approved these changes
Apr 14, 2022
I don't have a strong opinion either way. Happy to make the change! |
bmarty
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Changes destination when joining space to explore space rooms (instead of not navigating anywhere)
Motivation and context
Closes #5334
I only applied this change when joining a room from the HomeActivity (from both the hamburger menu and opening a notification). Looking at the code, there are other places where you can join the space e.g. RoomDetailActivity, but I would have to guess it's more intentional that we don't navigate away from those destinations
Screenshots / GIFs
TBA
Tests
Tested devices
Checklist