Live Location Sharing - Update beacon info state event when sharing is ended #5758
Conversation
onurays
requested review from
a team and
mnaturel
and removed request for
a team
| @@ -140,6 +145,25 @@ class LocationSharingService : VectorService(), LocationTracker.Callback { | |||
| } | |||
| } | |||
|
|
|||
| private fun updateStoppedBeaconInfo(roomId: String) { | |||
There was a problem hiding this comment.
To clarify namings what do you think about renaming this method to sendStoppedBeaconInfo() and the method sendBeaconInfo() to sendLivedBeaconInfo() ?
| override fun onServiceConnected(className: ComponentName, binder: IBinder) { | ||
| locationSharingService = (binder as LocationSharingService.LocalBinder).getService() |
There was a problem hiding this comment.
Should we reset locationSharingService to null in onServiceDisconnected for safety reason?
| ?.let { session -> | ||
| session.coroutineScope.launch(session.coroutineDispatchers.io) { | ||
| val room = session.getRoom(roomId) | ||
| EventType |
There was a problem hiding this comment.
I think we also need to add a filter to get all state events with lived=true. Normally there should be only a single live beacon per user per room. Maybe we need to extract it into a dedicated method to use it also in sendLiveLocation. I see in this last method 2 missing filters: the state_key=userId and lived=true which will be solved by this new method.
There was a problem hiding this comment.
Moved to an helper function.
No description provided.