Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client should notify others of the accepted verification request #5724

Closed
langleyd opened this issue Apr 8, 2022 · 0 comments · Fixed by #5916
Closed

Client should notify others of the accepted verification request #5724

langleyd opened this issue Apr 8, 2022 · 0 comments · Fixed by #5916
Assignees
@jmartinesp
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@langleyd
Copy link
Member

langleyd commented Apr 8, 2022 •
edited
Loading

Similar to element-hq/element-ios#4470

The Android client should notify other devices when one accepts a verification request. All other devices (other than the current device and the accepting device should cancel the existing verification request prompts)

Reproduced this issue on the android client.

Steps:

  1. Login + verify on a web client with alice
  2. Login + verify on a second web client with alice
  3. Login on Android with alice and click "verify this login"
  4. 2 verification requests appear, 1 on each web client.
  5. Accept 1 request.
    Expected: The request on the second web client should be dismissed
    Observed: The request on the second web client is not dismissed.
@langleyd langleyd added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-E2EE-Cross-Signing labels Apr 8, 2022
@langleyd langleyd self-assigned this Apr 8, 2022
@langleyd langleyd mentioned this issue Apr 8, 2022
Merged
1 task
@ericdecanini ericdecanini added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 11, 2022
@langleyd langleyd assigned jmartinesp and unassigned langleyd Apr 29, 2022
@jmartinesp jmartinesp mentioned this issue May 3, 2022
Merged
15 tasks
@langleyd langleyd linked a pull request May 11, 2022 that will close this issue
Notify other devices of acceptance of verification request #5916
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notify other devices of acceptance of verification request element-hq/element-android
3 participants
@jmartinesp @langleyd @ericdecanini