Fix rooms section collapsing #5616
Conversation
Florian14
requested review from
a team and
fedrunov
and removed request for
a team
Florian14
force-pushed
the
hotfix/fre/collapse_rooms_section
branch
from
43136b9
to
3c73ccc
Compare
Florian14
requested review from
a team and
onurays
and removed request for
a team
Ktlint Results👎 |
| @@ -44,11 +45,12 @@ class SectionHeaderAdapter constructor( | |||
| val shouldShowExpandedArrow: Boolean = false | |||
| ) | |||
|
|
|||
| lateinit var roomsSectionData: RoomsSectionData | |||
| var roomsSectionData: RoomsSectionData = roomsSectionData | |||
There was a problem hiding this comment.
ah it's using the value from the constructor. A bit confusing
There was a problem hiding this comment.
it is to prevent the lateinit declaration of the attribute and the initialization check of the attribute which was previously done in the updateSection method. I force passing the value as a constructor param and I init the attribute with that value. Previously, the attribute was initialized directly after creating the class object. I could set a different name to the param for clarity.
|
Fixes #4533 (to prevent from non intended collapse of the section). |
Type of change
Content
Fix inconsistencies between the arrow visibility and the collapse action by clicking on a room section header.
Motivation and context
The sections were always collapsible even if the arrow was not visible. Adding favourites in both DM and Rooms tab was causing issues on the arrow visibility for this section.
Screenshots / GIFs
Tests
Tested devices
Checklist