Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving all rooms in a Space should exclude private rooms #5609

Closed
TheEvilSkeleton opened this issue Mar 22, 2022 · 1 comment · Fixed by #5720
Closed

Leaving all rooms in a Space should exclude private rooms #5609

TheEvilSkeleton opened this issue Mar 22, 2022 · 1 comment · Fixed by #5720
Assignees
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@TheEvilSkeleton
Copy link

Your use case

What would you like to do?

Leaving all rooms in a space should exclude private rooms.

Why would you like to do it?

I personally believe it is a regression because people will likely think this is meant to leave every room in a given Space, not private rooms like DMs and groups.

How would you like to achieve it?

Leaving a space along with all rooms should not include private rooms, like DMs and groups

Have you considered any alternatives?

No response

Additional context

Personal story: this morning I left two spaces along with all its rooms. Little did I know, this also left private rooms (DMs and groups), which was not what I anticipated. I had to create rooms for all the rooms I left.

@TheEvilSkeleton TheEvilSkeleton added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 22, 2022
@kittykat
Copy link
Contributor

kittykat commented Apr 7, 2022

Leaving DMs is a bug, leaving a private room is intentional as it would be a problem if a user did not leave e.g. all their work private rooms when leaving their work space.

I can reproduce the issue with leaving DMs.

I'm going to re-triage this as a regression around leaving a space and DMs.

@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Apr 7, 2022
@fedrunov fedrunov self-assigned this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants