Avoid accessing realm instance from suspend functions #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessing the realm instance (thread local)
ariskotsomitopoulos
changed the title
ouchadam
reviewed
Mar 21, 2022
| @@ -101,9 +101,7 @@ internal class TimelineEventDecryptor @Inject constructor( | |||
| executor?.execute { | |||
| Realm.getInstance(realmConfiguration).use { realm -> | |||
| try { | |||
| runBlocking { | |||
There was a problem hiding this comment.
if the aim is to ensure the realm instance is only executed on a single thread it might be safer to keep the runBlocking here next to the instance creation
There was a problem hiding this comment.
I wanted to avoid making the function processDecryptRequest suspended. However, I can see the benefit you describe.
|
it's a bit tricky to tell from the diff, where does the thread jumping happen? I was expecting to see a |
|
From my understanding without |
BillCarsonFr
requested changes
Apr 21, 2022
BillCarsonFr
approved these changes
Apr 21, 2022
…nd_functions # Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TimelineEventDecryptor.kt # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
ariskotsomitopoulos
deleted the
feature/aris/prevent_decryption_fom_suspend_functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runBlocking when decrypt events to avoid thread switching when accessing the realm instance (thread local)