Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MergedRoomCreationItem] DM: RoomDescriptionText use the roomName instead of memberName #5570

Closed
Claire1817 opened this issue Mar 17, 2022 · 1 comment
Closed

[MergedRoomCreationItem] DM: RoomDescriptionText use the roomName instead of memberName #5570

Claire1817 opened this issue Mar 17, 2022 · 1 comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@Claire1817
Copy link
Contributor

Steps to reproduce

Create a DM with someone and update the name of the room.
The room description text will use the room name instead of the other member name.
Screenshot_20220317-154827_Element

Outcome

We should use data.memberName instead roomSummary?.displayName

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No
@Claire1817 Claire1817 added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 17, 2022
@Claire1817 Claire1817 added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Mar 17, 2022
@giomfo giomfo mentioned this issue Mar 29, 2022
Closed
@Claire1817 Claire1817 self-assigned this Apr 6, 2022
@Claire1817 Claire1817 mentioned this issue Apr 6, 2022
Merged
15 tasks
@giomfo giomfo mentioned this issue May 13, 2022
Closed
@giomfo
Copy link
Member

giomfo commented May 13, 2022

@Claire1817 we will revert PR#5705 because of the new issue #6032

This issue will stay open. We need design inputs to handle correctly the wording in a DM for which a name has been define

@Claire1817 Claire1817 mentioned this issue May 13, 2022
Merged
15 tasks
@Claire1817 Claire1817 removed their assignment May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giomfo @Claire1817