Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local echos not being shown when re-opening rooms #5551

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

SpiritCroc
Copy link
Contributor

Signed-off-by: Tobias Büttner [email protected]

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Make sure we have frozen results for SendingEventsDataSource right when starting it

Motivation and context

When you open a room which already has local echos, these wouldn't show until you create a new one.

Tests

  1. send message while offline
  2. close room
  3. re-open room
    => Own messages are not showing, until we sync them back after they reached the server, or we send another new message.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@ouchadam ouchadam requested review from ganfra March 16, 2022 11:04
@ouchadam ouchadam added Z-Community-PR Issue is solved by a community member's PR labels Mar 16, 2022
@ouchadam
Copy link
Contributor

the change looks reasonable to me 💯 have looped in @ganfra as a reviewer

1 similar comment
@ouchadam
Copy link
Contributor

the change looks reasonable to me 💯 have looped in @ganfra as a reviewer

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@ganfra ganfra merged commit 794131d into element-hq:develop Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants