-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add presence indicator online #5513
add presence indicator online #5513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new PR.
No problem on the implementation side 👍
Can I ask you to add a file changelog.d/5513.misc
with a line explaining the change? It will end up in the main changelog file during the next release.
More details can be found here: https://github.com/vector-im/element-android/blob/main/CONTRIBUTING.md#changelog
I could not get gradle to build with the newest from develop, so I couldn't test properly but I have tested on a fork... |
I've checked out the build locally and had no issues, thanks for the update 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a tiny change to the changelog to reflect this is a new attribute
Co-authored-by: Adam Brown <[email protected]>
Type of change
Content
Added presence indicator online like it is done for offline
Motivation and context
Consistency and easier to customise.
Screenshots / GIFs
Tests
Tested devices
Checklist
Signed-off-by: Chagai Friedlander [email protected]