Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfriendly message in display name error dialog #5418

Closed
ouchadam opened this issue Mar 3, 2022 · 1 comment · Fixed by #5419
Closed

Unfriendly message in display name error dialog #5418

ouchadam opened this issue Mar 3, 2022 · 1 comment · Fixed by #5419
Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ouchadam
Copy link
Contributor

ouchadam commented Mar 3, 2022

Your use case

What would you like to do?

Avoid printing raw exceptions as user facing messages

Why would you like to do it?

To improve the message readability

How would you like to achieve it?

By reusing the error dialog which translates exceptions to human readable messages

Have you considered any alternatives?

No response

Additional context

Screenshot_20220303_155653
@ouchadam ouchadam added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Settings labels Mar 3, 2022
@ouchadam ouchadam mentioned this issue Mar 3, 2022
Merged
6 tasks
@bmarty
Copy link
Member

bmarty commented Mar 3, 2022

Fixed in 1.4.4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Settings T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Giving avatar/display name error dialogs human readable error messages element-hq/element-android
2 participants
@ouchadam @bmarty