Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to Material 1.5.0 (dependency only) #5392

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Mar 1, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Upgrading the material library dependency from 1.4.0 > 1.5.0 without any other changes

Motivation and context

There's another PR up that implements a design change to upgrade our material components themselves to the new Material You design scheme.

This however is a decision that design needs to make and may take a while.

So while I continue to maintain that PR in the midst of that decision, this PR simply serves as an upgrade to keep our dependencies up-to-date without any user-facing changes.

This being merge would thus close Issue 5291. I would however recommend a new issue be raised for the upgrade of the app's look to Material You

**I'm currently testing that this indeed doesn't change anything user-facing

Screenshots / GIFs

N/A

Tests

  • Smoke test around the app seeing that the UI is unchanged
  • Confirm this through the debug menu pages

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 10

Checklist

@ericdecanini ericdecanini changed the title Upgrades to material 1.5.0 library Upgrades to Material 1.5.0 (dependency only) Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results

  88 files  ±0    88 suites  ±0   1m 13s ⏱️ +12s
159 tests ±0  159 ✔️ ±0  0 💤 ±0  0 ±0 
512 runs  ±0  512 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b1c2bcc. ± Comparison against base commit 1b1a9bf.

♻️ This comment has been updated with latest results.

@ericdecanini ericdecanini marked this pull request as ready for review March 1, 2022 14:17
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the separate PR and for the smoke test!

@bmarty bmarty merged commit 7e909de into develop Mar 1, 2022
@bmarty bmarty deleted the eric/update-material-library-version branch March 1, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to material 1.5.0 (or 1.6.0)
2 participants