Skip to content

Wrong display name in search result for user #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittykat opened this issue Feb 23, 2022 · 6 comments · Fixed by #5618
Closed

Wrong display name in search result for user #5321

kittykat opened this issue Feb 23, 2022 · 6 comments · Fixed by #5618
Assignees
Labels
A-Display name T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@kittykat
Copy link
Contributor

kittykat commented Feb 23, 2022

Steps to reproduce

Not sure how to reproduce:

Screenshot_20220223-122439.png

Expected outcome

Danielle is called "Danielle"

Your phone model

No response

Operating system version

No response

Application version and app store

1.4.0 / SDK 1.3.19 / olm 3.2.10

Homeserver

matrix.org

Will you send logs?

Yes

@kittykat kittykat added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 23, 2022
@daniellekirkwood
Copy link
Contributor

For context... I set my DisplayName to be Jano in the Threads P0 Delivery room (which @kittykat is a member of). My Display name is only changed in that room (using /myroomnick on web) and so I believe the correct behaviour here is to show my regular nickname/display name not the one that is specific only to the Threads P0 Delivery room

@kittykat
Copy link
Contributor Author

I can confirm that I was trying to invite Danielle from an unrelated room in the Element space

@daniellekirkwood
Copy link
Contributor

The behaviour of room-only display names should be such that it only applies inside of that room.

@bmarty do you have any background on this? Do you agree that the behaviour should be that we do not show room specific display names in the search results?

I'm testing on iOS now...

@daniellekirkwood daniellekirkwood added the Z-WTF WTF moment: High Impact, Low Effort label Feb 23, 2022
@daniellekirkwood
Copy link
Contributor

This does not happen on iOS.

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 23, 2022
@ericdecanini ericdecanini self-assigned this Mar 23, 2022
@ericdecanini
Copy link
Contributor

ericdecanini commented Mar 23, 2022

image

Fix is on the way, but I should also highlight that this bug in its entirety is that using /myroomnick currently changes your display name across the entire app. This affects not only your search result name, but also your name beside your avatar in the navigation drawer and such.

This fortunately doesn't affect your display name in other rooms (existing or new), but another weird fact about this bug is that whenever you send a message in a room, your display name in the app will be changed to whatever your nickname is in that room

@bmarty
Copy link
Member

bmarty commented Apr 13, 2022

Fixed in 1.4.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Display name T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants