Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also record next_batch on /sync response #5318

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

erikjohnston
Copy link
Member

In the same vein as #5312.

@erikjohnston erikjohnston marked this pull request as ready for review February 23, 2022 11:24
@github-actions
Copy link

Unit Test Results

  84 files  ±0    84 suites  ±0   56s ⏱️ -16s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 10b07c3. ± Comparison against base commit 3707b4e.

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1 @@
Log the `since` token used and `next_batch` token returned when doing an incremental sync.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only updating the other file is enough, but do not worry I will delete this one later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I figured I may as well combine the two PRs into a changelog entry (as they really should have been one PR), but YMMV :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FTR towncrier merges multiple changelog files with the same content into a single line in the final changelog)

@bmarty bmarty merged commit 9e9dc1d into develop Feb 23, 2022
@bmarty bmarty deleted the erikj/log_since_token branch February 23, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants