Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fga/improve bubble layout #5303

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Feb 22, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : UI improvement

Content

Increase vertical padding of Bubbles and timestamp position of Text Message cells to better wraps around the text.

Motivation and context

Fix ##5159

Screenshots / GIFs

BEFORE AFTER
bubble_before bubble_after

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Unit Test Results

  84 files  ±0    84 suites  ±0   1m 9s ⏱️ +10s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9911233. ± Comparison against base commit 79b511b.

♻️ This comment has been updated with latest results.

@ganfra ganfra force-pushed the feature/fga/improve_bubble_layout branch from b6f1c13 to 9911233 Compare February 22, 2022 17:07
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 6e7aa01 into develop Feb 22, 2022
@bmarty bmarty deleted the feature/fga/improve_bubble_layout branch February 22, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants