Cleanup config #5254
Merged
Cleanup config #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
|
Icon displayed on Android Studio, there may be other places where it's used:
|
ouchadam
reviewed
Feb 18, 2022
| @@ -21,7 +22,7 @@ | |||
| <string name="pusher_app_id" translatable="false">im.vector.app.android</string> | |||
|
|
|||
| <!-- preferred jitsi domain --> | |||
| <string name="preferred_jitsi_domain" translatable="false">jitsi.riot.im</string> | |||
| <string name="preferred_jitsi_domain" translatable="false">meet.element.io</string> | |||
There was a problem hiding this comment.
out of interest, is there a ticket with this request? wondering if there's some other tickets we can link to help leave a paper trail
There was a problem hiding this comment.
I do not think so. I could have created one, or maybe the people working on the Jitsi configuration could have created issues on each Element clients...
Related PR on EleWeb (I didn't find any issue either):
ouchadam
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the file config.xml and change default jitsi domain from
jitsi.riot.imtomeet.element.io. Jitsi conf are still working. As a bonus I added an icon to this project!