Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generic location pin #5146

Closed
onurays opened this issue Feb 3, 2022 · 0 comments · Fixed by #5127
Closed

Support generic location pin #5146

onurays opened this issue Feb 3, 2022 · 0 comments · Fixed by #5127
Assignees
@onurays
Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@onurays
Copy link
Contributor

onurays commented Feb 3, 2022

Your use case

  • Location does not always belong to a user
  • If m.asset type is not m.self we should render a generic location instead of user's avatar

Have you considered any alternatives?

No response

Additional context

No response
@onurays onurays added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Location labels Feb 3, 2022
@onurays onurays self-assigned this Feb 3, 2022
@onurays onurays linked a pull request Feb 3, 2022 that will close this issue
Support generic location pin #5127
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurays onurays

Labels
A-Location T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support generic location pin element-hq/element-android
1 participant
@onurays