-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning use case tracking with iOS #5142
Conversation
- resetting values to null may cause inconsistent cross device tracking
…no longer need to reset the tracking value
Matrix SDKIntegration Tests Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small remark about the changelog.
changelog.d/5142.bugfix
Outdated
@@ -0,0 +1 @@ | |||
Aligns use case identifying with iOS implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe prefix the content with Analytics:
else it can be a bit confusing.
Or create a new extension for towncrier .analytics
which will end to a dedicated section in the Changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new section could be handy 🤔 I think for now the prefix might be enough~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligning use case user property tracking with iOS