Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning use case tracking with iOS #5142

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Feb 3, 2022

Aligning use case user property tracking with iOS

  • Filters out null user properties as we want to avoid 1 device resetting values for others, we allow new non absent values to be set
  • Delays applying the use case property until the point of account creation to avoid needing to reset the value.

- resetting values to null may cause inconsistent cross device tracking
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Unit Test Results

  76 files  ±0    76 suites  ±0   56s ⏱️ -2s
144 tests ±0  144 ✔️ ±0  0 💤 ±0  0 ±0 
452 runs  ±0  452 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 3f3cac0. ± Comparison against base commit dbfd7e6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="25" failures="17" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="5" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.internal]
    passed="158" failures="13" errors="0" skipped="38"
  • [org.matrix.android.sdk.ordering]
    passed="16" failures="0" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="2" failures="0" errors="0" skipped="0"

Base automatically changed from feature/adm/enable-use-case-feature to develop February 3, 2022 15:14
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small remark about the changelog.

@@ -0,0 +1 @@
Aligns use case identifying with iOS implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe prefix the content with Analytics: else it can be a bit confusing.
Or create a new extension for towncrier .analytics which will end to a dedicated section in the Changelog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new section could be handy 🤔 I think for now the prefix might be enough~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganfra ganfra merged commit b75fd18 into develop Feb 7, 2022
@ganfra ganfra deleted the feature/adm/set-usecase-on-account-creation branch February 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants