Ensure mapbox legal mention are displayed on the map #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix SDKIntegration Tests Results:
|
ouchadam
approved these changes
Jan 26, 2022
|
great catch! |
ouchadam
reviewed
Jan 26, 2022
| @@ -7,7 +7,9 @@ | |||
| <im.vector.app.features.location.MapTilerMapView | |||
There was a problem hiding this comment.
not a blocker, something I noticed in the file layout - we could flatten the nested constraint layouts by using a Group with a background for the bottom bar
There was a problem hiding this comment.
Yes, Using a Flow is better. 6107fb6
bmarty
commented
Jan 26, 2022
| android:id="@+id/shareLocationContainer" | ||
| android:layout_width="0dp" | ||
| android:layout_height="72dp" | ||
| android:background="?android:colorBackground" | ||
| android:paddingStart="@dimen/layout_horizontal_margin" |
There was a problem hiding this comment.
16dp, was 12dp before, more compliant with the guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not hide the legal mention at bottom left of the map.
Note: The legal mention is correctly displayed in the timeline, in the message bottom sheet and in the location message detail.