Speed up event match regex evaluation for big messages #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`regex.containsMatchIn()` for `.*@room.*` can take significantly longer than checking for `@room` (some real-world events I was getting took around 15 seconds with this, significantly slowing down the sync parsing). Checking `containsMatchIn()` does not lead to different results when having leading and trailing stars however, it will match in the same cases as when these are omitted. For testing purposes, I sent myself some Lorem Ipsum with 5000 words (not containing any @room). Without this change, the regex evaluation takes about 16 seconds. With this change, the regex evaluation now takes significantly less then a second.
ouchadam
reviewed
Jan 21, 2022
| val modPattern = if (pattern.hasSpecialGlobChar()) | ||
| // Regex.containsMatchIn() is way faster without leading and trailing | ||
| // stars, that don't make any difference for the evaluation result | ||
| pattern.removePrefix("*").removeSuffix("*").simpleGlobToRegExp() |
There was a problem hiding this comment.
TIL! 💯
not a blocker for the PR (assuming this is working as intended), this class would be a great candidate for some unit tests
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex.containsMatchIn()for.*@room.*can take significantly longerthan checking for
@room(some real-world events I was getting tookaround 15 seconds with this, significantly slowing down the sync
parsing).
Checking
containsMatchIn()does not lead to different results whenhaving leading and trailing stars however, it will match in the same
cases as when these are omitted.
For testing purposes, I sent myself some Lorem Ipsum with 5000 words
(not containing any
@room).Without this change, the regex evaluation takes about 16 seconds.
With this change, the regex evaluation now takes significantly less then
a second.
Signed-off-by: Tobias Büttner [email protected]
Pull Request Checklist