Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including onboarding auth options in sanity test #4975

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Including onboarding auth options in sanity test #4975

merged 6 commits into from
Jan 18, 2022

Conversation

ouchadam
Copy link
Contributor

Adds crawling the get started and I already have an account onboarding flows to the sanity test

GIF
after-sanity

Base automatically changed from hotfix/1.3.15 to develop January 18, 2022 13:23
@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited
Loading

Unit Test Results

  68 files  ±0    68 suites  ±0   1m 7s ⏱️ +13s
136 tests ±0  136 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
420 runs  ±0  420 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70a95fc. ± Comparison against base commit 4976138.

♻️ This comment has been updated with latest results.

@ouchadam ouchadam force-pushed the feature/adm/ftue-sanity-test-updates branch from 1422391 to 70a95fc Compare January 18, 2022 16:21
@ouchadam ouchadam marked this pull request as ready for review January 18, 2022 16:21
@ouchadam ouchadam mentioned this pull request Jan 18, 2022
Closed
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="21" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="5" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.internal]
    passed="23" failures="1" errors="0" skipped="3"
  • [org.matrix.android.sdk.ordering]
    passed="16" failures="0" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="2" failures="0" errors="0" skipped="0"

bmarty
bmarty approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bmarty bmarty merged commit 488486a into develop Jan 18, 2022
@bmarty bmarty deleted the feature/adm/ftue-sanity-test-updates branch January 18, 2022 18:04
@ouchadam ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @bmarty