Fix crash on API <24 and make sure this error will not occur again. #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
force-pushed
the
feature/bma/1_3_14_crashes
branch
from
54a2fcf
to
8f30e84
Compare
bmarty
changed the title
bmarty
commented
Jan 17, 2022
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { | ||
| removeIf(predicate) | ||
| } else { | ||
| removeAll(filter(predicate).toSet()) |
There was a problem hiding this comment.
I have been asked to convert to Set for performance reason.
There was a problem hiding this comment.
as this is only for the keys to remove there shouldn't be any changes for lists with duplicated items?
listOf(1, 1, 2).removeIfCompat { it == 2 } // would still expect [1, 1] There was a problem hiding this comment.
Now that you say it, I am not sure what will happen with
listOf(1, 1, 2).removeIfCompat { it == 1 } // would still expect [2] but I think we will get [1, 2]
Let me play a bit with it.
There was a problem hiding this comment.
Seems to work as expected:
(https://pl.kotl.in/vIVLDMXe-)
ouchadam
approved these changes
Jan 17, 2022
ouchadam
reviewed
Jan 17, 2022
| @@ -40,6 +40,7 @@ | |||
| <issue id="RtlSymmetry" severity="error" /> | |||
|
|
|||
| <!-- Code --> | |||
| <issue id="NewApi" severity="error" /> | |||
Matrix SDKIntegration Tests Results:
|
37 tasks
|
Now included in #4971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash on API <24 and make sure this error will not occur again.