Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking phones to portrait during FTUE onboarding #4918

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Locking phones to portrait during FTUE onboarding #4918

merged 2 commits into from
Jan 13, 2022

Conversation

ouchadam
Copy link
Contributor

Part of #4584

  • Makes use of a resource bucket flag to determine if the device is big enough to be considered a tablet and in turn, enable a landscape experience in the FTUE auth onboarding flow
BEFORE PHONE AFTER PHONE AFTER LOGIN AFTER TABLET
before-rotation after-rotation after-login tablet-rotation

@ouchadam
locking phones to portait during the ftue auth onboarding flow
ce7a93b 
- uses a resource bucket flag for determining if the device is big enough to be considered a tablet and in turn, enable a landscape experience
@ouchadam ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Jan 11, 2022
@github-actions
Copy link

github-actions bot commented Jan 11, 2022 •
edited
Loading

Unit Test Results

  66 files  ±0    66 suites  ±0   52s ⏱️ -4s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6f8533c. ± Comparison against base commit 848a7f4.

♻️ This comment has been updated with latest results.

@ouchadam ouchadam mentioned this pull request Jan 12, 2022
Closed
10 tasks
bmarty
bmarty approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

library/ui-styles/src/main/res/values/tablet.xml
@@ -2,5 +2,6 @@
<resources>

<dimen name="width_percent">1</dimen>
<bool name="is_tablet">false</bool>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird to see that in a file (that I) named tablet.xml :)

@bmarty
Copy link
Member

bmarty commented Jan 13, 2022

Can I ask you to add the same rotation lock to the Activity AnalyticsOptInActivity please? I do not see any other screen where it could be applied at the moment.

Thanks!

@ouchadam
Copy link
Contributor Author

ouchadam commented Jan 13, 2022 •
edited
Loading

Can I ask you to add the same rotation lock to the Activity AnalyticsOptInActivity please? I do not see any other screen where it could be applied at the moment.

Thanks!

will do 👍 6f8533c

@bmarty bmarty self-requested a review January 13, 2022 09:53
bmarty
bmarty approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="21" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="5" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.internal]
    passed="158" failures="12" errors="0" skipped="38"
  • [org.matrix.android.sdk.ordering]
    passed="16" failures="0" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="2" failures="0" errors="0" skipped="0"

@ouchadam ouchadam merged commit 18207da into develop Jan 13, 2022
@ouchadam ouchadam deleted the feature/adm/lock-ftue-onboarding-to-portrait branch January 13, 2022 12:43
@ouchadam ouchadam mentioned this pull request Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @bmarty