Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align toolbar usage #4884

Closed
fedrunov opened this issue Jan 9, 2022 · 0 comments · Fixed by #4887
Closed

Align toolbar usage #4884

fedrunov opened this issue Jan 9, 2022 · 0 comments · Fixed by #4887
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-WTF WTF moment: High Impact, Low Effort

Comments

@fedrunov
Copy link
Contributor

fedrunov commented Jan 9, 2022

Your use case

What would you like to do?

Align the way toolbar is managed across the app

Why would you like to do it?

Currently on some screens toolbar's title, subtitle and navigation button (back button) are defined separately as roolbar's children, while on the other screens built-in toolbar's methods and widgets are used. This leads to a different margins, size and text appeareance.

How would you like to achieve it?

there are 4 main use cases of toolbar in the app:

  1. default one with just title, subtitle, navigation button and action buttons
  2. default one + tabs control
  3. default one + search
  4. compex cases with a lot of widgets and/or custom position and appearance of title and subtitle

for first 3 cases toolbar's internal widgets can be utilized and also toolbar can be extracted to a separate resource file and included in a view. This will ensure consistancy between the screens and also will allow to write helper methods/builder to manage this casese

for 4th case it's not possible to reuse layout, but extracting toolbar to a separate layout file for each screen could make laoyuts easier to read. Incorporating this cases to a builder from previous paragraph is tricky and could not give a lot of benefit I think, so it wil be better to keep accessing widgets inside toolbar via bindings as it is now. But at least for title and subtitle text appearances from styles_toolbar.xml could be used (if fit design) to make it consistent with others and also to ease possible changes

Have you considered any alternatives?

No response

Additional context

Differences in layout

image Main Screen
image Create room

@fedrunov fedrunov added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 9, 2022
@fedrunov fedrunov linked a pull request Jan 10, 2022 that will close this issue
@daniellekirkwood daniellekirkwood added Z-WTF WTF moment: High Impact, Low Effort X-Needs-Design May require input from the design team labels Jan 10, 2022
@fedrunov fedrunov self-assigned this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants