Updated splash carousel images and copy #4880

ouchadam · 2022-01-07T17:14:56Z

Part of #4584

Updates the carousel images and copy to match the latest from the designs, including new dark mode assets https://www.figma.com/file/xdV4PuI3DlzA1EiBvbrggz/Login-Flow-v2?node-id=2235%3A41941
Adds dark mode item background
Styles the terminating full stop in the titles

1	2	3	4

TABLET PORTRAIT	TABLET LANDSCAPE	SMALL PHONE	MULTI WINDOW	MULTI WINDOW

ouchadam · 2022-01-07T17:15:39Z

vector/src/main/java/im/vector/app/features/onboarding/ftueauth/SplashCarouselStateFactory.kt

+        private val stringProvider: StringProvider
+) {
+
+    fun create() = SplashCarouselState(listOf(


the state creation has been extracted out to a dedicated factory as we need to apply some span logic to the terminating .

ouchadam · 2022-01-07T17:16:28Z

vector/src/main/res/layout/item_splash_carousel.xml

@@ -39,7 +39,7 @@

        <ImageView
            android:id="@+id/carousel_item_image"
-            android:layout_width="wrap_content"
+            android:layout_width="match_parent"


now that we have consistent bounding boxes we can matching the parent (which is constrained by gutters)

ouchadam · 2022-01-07T17:53:22Z

vector/src/main/java/im/vector/app/features/onboarding/ftueauth/SplashCarouselStateFactory.kt

+
+    private fun Int.colorTerminatingFullStop(@AttrRes color: Int): EpoxyCharSequence {
+        val string = stringProvider.getString(this)
+        val fullStop = "."


this is incredibly decoupled from the input text to allow languages which don't use full stops to be skipped, maybe a good idea or a terrible one, I'm not sure yet.

It looks acceptable to me like this. Not a big deal anyway.

github-actions · 2022-01-07T18:02:25Z

Unit Test Results

  66 files ±0   66 suites ±0 49s ⏱️ -3s
135 tests ±0 135 ✔️ ±0 0 💤 ±0 0 ❌ ±0
418 runs ±0 418 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 1528238. ± Comparison against base commit f025554.

♻️ This comment has been updated with latest results.

bmarty

Thanks, just some thoughts.

bmarty · 2022-01-07T18:05:37Z

vector/src/main/java/im/vector/app/features/onboarding/ftueauth/SplashCarouselStateFactory.kt

+
+    private fun Int.colorTerminatingFullStop(@AttrRes color: Int): EpoxyCharSequence {
+        val string = stringProvider.getString(this)
+        val fullStop = "."


It looks acceptable to me like this. Not a big deal anyway.

bmarty · 2022-01-07T18:09:05Z

vector/src/main/java/im/vector/app/features/onboarding/ftueauth/SplashCarouselStateFactory.kt

+    private fun Int.colorTerminatingFullStop(@AttrRes color: Int): EpoxyCharSequence {
+        val string = stringProvider.getString(this)
+        val fullStop = "."
+        val charSequence = if (string.endsWith(fullStop)) {


Wondering how it will work with RTL languages. Not critical anyway.

PSEUDO RTL

it doesn't work and the String behaviour is even stranger...

value: ‏‮Own‬‏ ‏‮your‬‏ ‏‮conversions.‬‏ first char: "‏" last char: "‏" starts with . : false, ends with . : false last index of . : 30, first index of . : 30 length: 33

What is "Pseudo RTL"? Even when forcing RTL from the developer option of my phone, is does not reverse the Strings like that.

they're fake languages for testing locales https://developer.android.com/guide/topics/resources/pseudolocales

TIL. But seems quite not useful if it breaks fun like endsWith.
I prefer to force the app to "Arabic" for instance in the "Choose language" screen.

bmarty · 2022-01-07T18:10:46Z

vector/src/main/res/drawable/ic_splash_collaboration.xml

+    android:viewportWidth="300"
+    android:viewportHeight="300">
+  <group>
+    <clip-path


pretty sure lint is already complaining about the complexity of those vectors...
Not a strong opinion neither, but probably quite bad for the performance than classical png/webp images

as these are one time use assets and they're quite complex I'll covert to .png

bmarty · 2022-01-07T18:12:05Z

vector/src/main/res/values/strings.xml

-    <string name="ftue_auth_carousel_3_title">Connect with anyone.</string>
-    <string name="ftue_auth_carousel_3_body">Element works with all Matrix-based apps and can even bridge into proprietary messengers.</string>
+    <string name="ftue_auth_carousel_3_title">Secure Messaging.</string>
+    <string name="ftue_auth_carousel_3_body">No phone number required, so you don\'t have to share those details with the outside world. No ads, no tracking or datamining.</string>


Is "no tracking" true regarding analytics? CC @daniellekirkwood

👀 Good catch, @bmarty

Even though we don't track without explicit consent from the user we'd like to change the content to remove the reference to tracking, that way it's super clear.

"No ads or datamining."

@ouchadam Is that ok?

sounds good to me 👍

bmarty · 2022-01-11T15:47:01Z

vector/src/main/res/values/strings_no_weblate.xml

@@ -10,4 +10,6 @@
    <!-- Value MUST have 4 letters and MUST be in this list: https://www.unicode.org/iso15924/iso15924-codes.html. Example:  "Arab", "Cyrl", "Latn", etc. -->
    <string name="resources_script">Latn</string>

+    <string name="cut_the_slack_from_teams">Cut the slack from teams.</string>


Maybe better to put it in this file and add the translatable="false" attribute

will do 👍

updated 2958644

ouchadam · 2022-01-12T09:25:52Z

keeping as a draft until we finalise the carousel copy

github-actions · 2022-01-14T09:51:47Z

Matrix SDK

Integration Tests Results:

[org.matrix.android.sdk.session]
passed="21" failures="0" errors="0" skipped="2"
[org.matrix.android.sdk.account]
passed="5" failures="0" errors="0" skipped="2"
[org.matrix.android.sdk.internal]
passed="23" failures="1" errors="0" skipped="3"
[org.matrix.android.sdk.ordering]
passed="16" failures="0" errors="0" skipped="0"
[org.matrix.android.sdk.PermalinkParserTest]
passed="2" failures="0" errors="0" skipped="0"

bmarty · 2022-01-14T16:50:34Z

vector/src/main/java/im/vector/app/features/onboarding/ftueauth/SplashCarouselItem.kt

@@ -35,7 +35,7 @@ abstract class SplashCarouselItem : VectorEpoxyModel<SplashCarouselItem.Holder>(

        holder.view.setBackgroundResource(item.pageBackground)
        holder.image.setImageResource(item.image)
-        holder.title.setText(item.title)
+        holder.title.text = item.title.charSequence


hopefully there is not Emoji there.

😅 we should be okay as we've using the EpoxyCharSequence and there's no setTextFuture 🤞

bmarty · 2022-01-14T16:51:57Z

vector/src/main/res/values/strings.xml

-    <string name="ftue_auth_carousel_2_body">Element lets you choose where you messages are stored, keeping you in control of your data.</string>
-    <string name="ftue_auth_carousel_3_title">Connect with anyone.</string>
-    <string name="ftue_auth_carousel_3_body">Element works with all Matrix-based apps and can even bridge into proprietary messengers.</string>
+    <string name="ftue_auth_carousel_2_body">Element lets you choose where your messages are stored, keeping you in control of your data.</string>


We should not use hard-coded Element in the string. Use ${app_name} and add template to the string key. (see other example in this file.

very good point, will update 👍

57ccf2d

also marks the previous strings for removal

bmarty

One last remark, sorry.

- also meant extracting out a separate state creation factory to avoid having too much logic inside the fragment

…equence

- also fixes the carousel text reposition based on line count

- marked as donottranslate whilst waiting for sign off - removed the positioning from the naming schema in favour of location of context

…ings

…pp name - also marks the now unused strings for deletion

bmarty

Thanks for the update

ouchadam commented Jan 7, 2022

View reviewed changes

ouchadam mentioned this pull request Jan 7, 2022

Build FTUE Splash screens #4584

Closed

10 tasks

bmarty reviewed Jan 7, 2022

View reviewed changes

Base automatically changed from feature/adm/automatic-splash-carousel-transitions to develop January 11, 2022 11:14

ouchadam force-pushed the feature/adm/carousel-images-update branch from a0bf2ed to 0e3068e Compare January 11, 2022 11:29

bmarty reviewed Jan 11, 2022

View reviewed changes

ouchadam force-pushed the feature/adm/carousel-images-update branch 2 times, most recently from 2958644 to 27377d3 Compare January 11, 2022 16:40

ouchadam force-pushed the feature/adm/carousel-images-update branch from 27377d3 to 774bed6 Compare January 14, 2022 09:08

ouchadam marked this pull request as ready for review January 14, 2022 16:12

ouchadam requested a review from bmarty January 14, 2022 16:14

bmarty reviewed Jan 14, 2022

View reviewed changes

ouchadam force-pushed the feature/adm/carousel-images-update branch 2 times, most recently from 8ceafb4 to f389e28 Compare January 14, 2022 17:37

ouchadam added 9 commits January 17, 2022 09:24

styling last full stop in the carousel titles to use the accent colour

19f328b

- also meant extracting out a separate state creation factory to avoid having too much logic inside the fragment

updating splash carousel images with latest designs

689c817

updating splash carousel copy to match latest copy

7c5e7a9

splitting the CharSequence creation from the conversion to EpoxyCharS…

bb2e3b1

…equence

fixing typo in carousel body

e521fd9

replacing onboarding vectors with png to avoid performance overheads

b137009

- also fixes the carousel text reposition based on line count

applying english override for the last carousel page copy

fbe60f5

including updated copy for the carousel

982b480

- marked as donottranslate whilst waiting for sign off - removed the positioning from the naming schema in favour of location of context

adding non light mode carousel background which uses a vertical gradient

c0b855e

ouchadam added 5 commits January 17, 2022 09:24

adding dark variants of the carousel images

43acc7a

applying percentage based heights to the carousel hero image and padd…

f4cacb2

…ings

fixing pixel rounding to 451x451, image should be 450x450

be319f5

using app name template for the carousel content which contains the a…

7d0b833

…pp name - also marks the now unused strings for deletion

adding changelog entry

1528238

ouchadam force-pushed the feature/adm/carousel-images-update branch from f389e28 to 1528238 Compare January 17, 2022 09:27

bmarty approved these changes Jan 17, 2022

View reviewed changes

ouchadam merged commit 256929b into develop Jan 17, 2022

ouchadam deleted the feature/adm/carousel-images-update branch January 17, 2022 15:11

ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated splash carousel images and copy #4880

Updated splash carousel images and copy #4880

ouchadam commented Jan 7, 2022 •

edited

Loading

ouchadam Jan 7, 2022

ouchadam Jan 7, 2022

ouchadam Jan 7, 2022

bmarty Jan 7, 2022

github-actions bot commented Jan 7, 2022 •

edited

Loading

bmarty left a comment

bmarty Jan 7, 2022

bmarty Jan 7, 2022

ouchadam Jan 10, 2022

bmarty Jan 10, 2022

ouchadam Jan 11, 2022

bmarty Jan 11, 2022

bmarty Jan 7, 2022

ouchadam Jan 11, 2022

ouchadam Jan 11, 2022 •

edited

Loading

bmarty Jan 7, 2022

daniellekirkwood Jan 11, 2022 •

edited

Loading

ouchadam Jan 11, 2022

bmarty Jan 11, 2022

bmarty Jan 11, 2022

ouchadam Jan 11, 2022

ouchadam Jan 11, 2022

ouchadam commented Jan 12, 2022

github-actions bot commented Jan 14, 2022 •

edited

Loading

bmarty Jan 14, 2022

ouchadam Jan 14, 2022

bmarty Jan 14, 2022 •

edited

Loading

ouchadam Jan 14, 2022

ouchadam Jan 14, 2022

bmarty left a comment

bmarty left a comment

Updated splash carousel images and copy #4880

Updated splash carousel images and copy #4880

Conversation

ouchadam commented Jan 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 7, 2022 • edited Loading

Unit Test Results

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ouchadam Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniellekirkwood Jan 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ouchadam commented Jan 12, 2022

github-actions bot commented Jan 14, 2022 • edited Loading

Matrix SDK

Integration Tests Results:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

ouchadam commented Jan 7, 2022 •

edited

Loading

github-actions bot commented Jan 7, 2022 •

edited

Loading

ouchadam Jan 11, 2022 •

edited

Loading

daniellekirkwood Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 14, 2022 •

edited

Loading

bmarty Jan 14, 2022 •

edited

Loading