Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain emojis crash on Android 12+ when used in notices #4743

Closed
ouchadam opened this issue Dec 16, 2021 · 0 comments · Fixed by #4744
Closed

Certain emojis crash on Android 12+ when used in notices #4743

ouchadam opened this issue Dec 16, 2021 · 0 comments · Fixed by #4744
Labels
A-Emoji A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ouchadam
Copy link
Contributor

Steps to reproduce

  1. Be on a android 12+ device
  2. Post a /me :tada:
  3. The room now crashes on entry

Outcome

What did you expect?

No crash!

What happened instead?

2021-12-16 18:25:59.939 14077-14077/im.vector.app.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: im.vector.app.debug, PID: 14077
    com.airbnb.epoxy.ImmutableModelException: The model was changed during the bind call. Position: 9 Model: MessageTextItem_{searchForPills=false, message=* 🎉, bindingOptions=null,

    Epoxy attribute fields on a model cannot be changed once the model is added to a controller. Check that these fields are not updated, or that the assigned objects are not mutated, outside of the buildModels method. The only exception is if the change is made inside an Interceptor callback. Consider using an interceptor if you need to change a model after it is added to the controller and before it is set on the adapter. If the model is already set on the adapter then you must call `requestModelBuild` instead to recreate all models.
        at com.airbnb.epoxy.EpoxyModel.validateStateHasNotChangedSinceAdded(EpoxyModel.java:466)
        at im.vector.app.features.home.room.detail.timeline.item.MessageTextItem_.handlePostBind(MessageTextItem_.java:59)

The is the same cause as #4691 but in another location

Your phone model

No response

Operating system version

12+

Application version and app store

No response

Homeserver

matrix.org

Will you send logs?

No

@ouchadam ouchadam added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Emoji A-Timeline S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant