Improve crypto log to debug UISI #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/crypto_better_logs
branch
from
fafb80f
to
feda53b
Compare
ouchadam
approved these changes
Nov 18, 2021
bmarty
requested changes
Nov 18, 2021
| val deviceId = deviceInfo.deviceId | ||
| val key = deviceInfo.identityKey() | ||
| if (key == null) { | ||
| Timber.w("## CRYPTO | Ignoring device (${deviceInfo.userId}|$deviceId) without identity key") |
There was a problem hiding this comment.
use a Timber tag in this file too?
| @@ -275,7 +285,7 @@ internal class MXMegolmEncryption( | |||
| gossipingEventBuffer.add( | |||
| Event( | |||
| type = EventType.ROOM_KEY, | |||
| senderId = this.userId, | |||
| senderId = this.myUserId, | |||
There was a problem hiding this comment.
I think this. is not necessary anymore here
| @@ -32,6 +33,8 @@ import org.matrix.android.sdk.internal.session.initsync.ProgressReporter | |||
| import timber.log.Timber | |||
| import javax.inject.Inject | |||
|
|
|||
| private val loggerTag = LoggerTag("MXMegolmEncryption", LoggerTag.CRYPTO) | |||
There was a problem hiding this comment.
MXMegolmEncryption ? It's maybe wanted.
There was a problem hiding this comment.
good catch (bad copy paste)
|
Thanks for the update.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update crypto logs to better help debug UISIs