Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content scanner service #4392

Merged
merged 7 commits into from
Nov 17, 2021
Merged

Add content scanner service #4392

merged 7 commits into from
Nov 17, 2021

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Nov 2, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

Unit Test Results

  66 files  +  4    66 suites  +4   48s ⏱️ -9s
135 tests +17  135 ✔️ +17  0 💤 ±0  0 ❌ ±0 
418 runs  +68  418 ✔️ +68  0 💤 ±0  0 ❌ ±0 

Results for commit 0fada97. ± Comparison against base commit 8b655ed.

♻️ This comment has been updated with latest results.

bmarty
bmarty reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Some remarks, also can you add a file for towncrier with .removal extension to notify SDK users about the new API?

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/Session.kt Outdated Show resolved Hide resolved
...id/src/main/java/org/matrix/android/sdk/api/session/contentscanning/ContentScannerService.kt Outdated Show resolved Hide resolved
...id/src/main/java/org/matrix/android/sdk/api/session/contentscanning/ContentScannerService.kt Outdated Show resolved Hide resolved
...id/src/main/java/org/matrix/android/sdk/api/session/contentscanning/ContentScannerService.kt Outdated Show resolved Hide resolved
...android/src/main/java/org/matrix/android/sdk/api/session/contentscanning/ContentScanError.kt Outdated Show resolved Hide resolved
...roid/src/main/java/org/matrix/android/sdk/internal/session/contentscanning/ContentScanApi.kt Outdated Show resolved Hide resolved
...roid/src/main/java/org/matrix/android/sdk/internal/session/contentscanning/ContentScanApi.kt Outdated Show resolved Hide resolved
...n/java/org/matrix/android/sdk/internal/session/contentscanning/ContentScanningApiProvider.kt Outdated Show resolved Hide resolved
.../src/main/java/org/matrix/android/sdk/internal/session/contentscanning/ScanEncryptorUtils.kt Outdated Show resolved Hide resolved
...in/java/org/matrix/android/sdk/internal/session/contentscanning/data/ContentScanningStore.kt Outdated Show resolved Hide resolved
@yostyle yostyle marked this pull request as ready for review November 4, 2021 16:39
@yostyle yostyle marked this pull request as draft November 4, 2021 16:40
@yostyle
Copy link
Contributor Author

yostyle commented Nov 4, 2021

Thanks for the PR. Some remarks, also can you add a file for towncrier with .removal extension to notify SDK users about the new API?

This PR is not yet ready.

@yostyle yostyle marked this pull request as ready for review November 10, 2021 20:50
@bmarty
Copy link
Member

bmarty commented Nov 15, 2021

Thanks for the PR. Some remarks, also can you add a file for towncrier with .removal extension to notify SDK users about the new API?

This PR is not yet ready.

Now that the PR is ready, can you do it please?

@bmarty bmarty merged commit 855b672 into develop Nov 17, 2021
@bmarty bmarty deleted the yostyle/content_scanner branch November 17, 2021 10:18
@bmarty bmarty mentioned this pull request Nov 17, 2021
Merged
@yostyle yostyle mentioned this pull request Nov 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yostyle @bmarty