When changing the message to be replied from image message to text/audio message the old image belonging to previously selected message should go away

[ryg-git]

Steps to reproduce

1. Open a room screen or DM screen.

2. Select a image message to reply either by swiping or from long press menu
   

3. Then while the image message is selected for the reply select another message (text or audio)

4. Now you will see that only text is replaced i.e image name is changed to selected message or file but the previously selected image doesn't go away.
   

5. Also if you select text message first and then you change message to be replied to image the selected image is not displayed only image file name is displayed.
   
   

Intended result and actual result

What did you expect?

When changing the message to be replied from image to text the old image should go away and only text belonging to newly selected message should be displayed,
Also if you select text message first to reply and then select image the image should also be displayed not only file name.

What happened instead?

If you select image first to reply and then change the message to be replied to text the image doesn't go away.
If you select text message first to reply and then select image the image is not displayed only file name is displayed.

Your phone model

Xiaomi redmi note 8 pro

Operating system version

Android 11

Application version and app store

Element android app version 1.3.3

Homeserver

matrix.org

Will you send logs?

No

[ryg-git]

If it is okay I would like to work on this issue

[ouchadam]

@ryg-git thanks for raising this and all the reproduction steps! A fix would be very welcome:+1:

I was also able to reproduce the same scenarios mentioned

IMAGE - TEXT	TEXT - IMAGE

[bmarty]

Fixed in #4490 and Element 1.3.9