Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new Thread by replying to a message in Timeline #4328

Closed
9 of 10 tasks
daniellekirkwood opened this issue Oct 25, 2021 · 4 comments
Closed
9 of 10 tasks

Start a new Thread by replying to a message in Timeline #4328

daniellekirkwood opened this issue Oct 25, 2021 · 4 comments
Assignees
Labels
A-Threads An issue for the Threads project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-ThreadsP0 Issue to be released with the Threads MVP

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Oct 25, 2021

As a user I want to start a new Thread from a message in the Timeline.

Long press on message to open options > start Thread is an option >

Short press is not included in the MVP/P0 version of Threads.

Following matrix-org/matrix-spec-proposals#3440

  • Add Reply In Thread option on long click
  • Display threads in the appropriate thread timeline
  • Send a regular message from threads
  • Send a Reply message from threads
  • Send a Quote message from threads
  • Send an Edit event from within threads
  • Indicate a message is a root thread (with a temp UI)
  • Use relation type m.thread to start Threads
  • Make sure that m.thread can be combined with m.in_reply_to to allow quote relies in threads

Added:

  • When user clicks "Reply in Thread" the message bar gets the focus so user can type reply immediately without the need for extra click
@daniellekirkwood daniellekirkwood transferred this issue from element-hq/element-meta Oct 25, 2021
@daniellekirkwood daniellekirkwood added A-Threads An issue for the Threads project X-Needs-Design May require input from the design team Z-ThreadsP0 Issue to be released with the Threads MVP labels Oct 25, 2021
@daniellekirkwood daniellekirkwood self-assigned this Oct 25, 2021
@ouchadam ouchadam added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 25, 2021
@daniellekirkwood daniellekirkwood added X-Needs-Product Issue needs input from Product team and removed X-Needs-Product Issue needs input from Product team labels Nov 1, 2021
@daniellekirkwood daniellekirkwood removed their assignment Nov 1, 2021
@daniellekirkwood
Copy link
Contributor Author

Needs-Product is a label on this issue because we need to reach a conclusion on the Short Press discussion.

@daniellekirkwood daniellekirkwood added the X-Needs-Product Issue needs input from Product team label Nov 1, 2021
@daniellekirkwood daniellekirkwood self-assigned this Nov 1, 2021
@daniellekirkwood
Copy link
Contributor Author

Removing the Needs-Product label as short press has been delayed to V2 of Threads and is not included in the MVP

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Issue needs input from Product team label Nov 12, 2021
@daniellekirkwood daniellekirkwood removed their assignment Nov 12, 2021
@daniellekirkwood
Copy link
Contributor Author

Removing Jano's assignment as Designs have been added to the issue

@janogarcia
Copy link

janogarcia commented Jan 7, 2022

@ariskotsomitopoulos We need to make sure that when the "Reply in thread" action is used the message composer input gets the focus automatically in the thread view, without requiring the user to manually tap on it to actually initiate the reply.

https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=1304%3A244131

@daniellekirkwood Could you please add it as a task/acceptance criteria to the issue description? Thanks!


Edit: Just to be clear, that behavior should only happen when following the "Reply in thread" action. This doesn't apply when just viewing a thread after tapping on a thread summary or a thread tile in the thread list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads An issue for the Threads project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-ThreadsP0 Issue to be released with the Threads MVP
Projects
None yet
Development

No branches or pull requests

4 participants