Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore rooms doesn't make good use of space #4304

Closed
kittykat opened this issue Oct 21, 2021 · 5 comments · Fixed by #5125
Closed

Explore rooms doesn't make good use of space #4304

kittykat opened this issue Oct 21, 2021 · 5 comments · Fixed by #5125
Assignees
Labels
A-Room-List A-Spaces Spaces, groups, communities help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-Testing Issues found during the community testing sessions

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 21, 2021

Steps to reproduce

  1. Where are you starting? What can you see?
  2. What do you click?
  3. More steps…

Intended result and actual result

What did you expect?

Explore rooms shows me list of rooms in a space (ideally it also tells me what space I'm looking at)

I am not expecting to know how many members a space has from the explore rooms view

e.g.
Screenshot_20211021-164325

What happened instead?

A large portion of the view is taken up with unused space and as a user, when I want to explore rooms, I'm not interested in the information about the space
Screenshot_20211021-164325 (1)

Application version and app store

Element 1.3.4 (RC)

Will you send logs?

No

@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team A-Room-List A-Spaces Spaces, groups, communities Z-Community-Testing Issues found during the community testing sessions labels Oct 21, 2021
@kittykat kittykat added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 14, 2022
@niquewoodhouse
Copy link

I think that's a good enough improvement to ship but, there are some things missing that would help people exploring:

  • Search
  • Labelling of 'subspaces'

@kittykat kittykat added help wanted Extra attention is needed and removed X-Needs-Design May require input from the design team labels Jan 18, 2022
@fedrunov fedrunov self-assigned this Feb 1, 2022
@fedrunov
Copy link
Contributor

fedrunov commented Feb 1, 2022

There are some extra places where same layout/design is used

When user tap on link invite to room
room_invite

when user tap on link invite to space
space_invite

@niquewoodhouse do we want to update all of them at once, or only "explore room" screen?

I suggest change everywhere but leave description and "people you might now" section visible for invites.

@niquewoodhouse
Copy link

I suggest change everywhere but leave description and "people you might now" section visible for invites.

@fedrunov that sounds good, thanks for suggesting

@fedrunov
Copy link
Contributor

fedrunov commented Feb 2, 2022

@niquewoodhouse small problem:

member count group has background and on black theme it's not visible at "explore room" screen. Since there is padding for image, it breaks left alignment of views

Invite Explore
invite explore

There is no problem on light theme - background is always visible.

I suggest we file this as a separate ticket with minor priority

@bmarty
Copy link
Member

bmarty commented Feb 2, 2022

Will be in Element 1.3.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-Spaces Spaces, groups, communities help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-Testing Issues found during the community testing sessions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants