Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions are lost on old events #4280

Closed
bmarty opened this issue Oct 20, 2021 · 1 comment · Fixed by #4405
Closed

Reactions are lost on old events #4280

bmarty opened this issue Oct 20, 2021 · 1 comment · Fixed by #4405
Assignees
@ganfra
Labels
A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bmarty
Copy link
Member

bmarty commented Oct 20, 2021

  • Send an Event
  • Add reaction(s) on it
  • Send lots of other events, restart the app, wait a few days, not sure what are the minimal path here
  • Scroll back to the first event

Observe that the reaction(s) has vanished

Major since reactions are not reliable
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Reactions S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 20, 2021
@ganfra
Copy link
Member

ganfra commented Oct 20, 2021

It's probably because of timeline chunk merging when back paginating (has to be confirmed).
If so, should be fixed by the started rework of chunks handling

@ganfra ganfra mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fga/timeline chunks rework element-hq/element-android
2 participants
@bmarty @ganfra