Feature/aris/issue_3902_add_scripts_to_ci

[ariskotsomitopoulos]

Fixes #3902

Implement a new github workflow to run :

./tools/import_emojis.py
./tools/import_sas_strings.py

every Monday at 00:00 UTC and create two PRs:

1. Sync Emojis
2. Sync SAS Strings

How the automated cron action behaves:

• If there are changes (i.e. a diff exists with the checked-out base branch), the changes will be pushed to a new branch and a pull request created.

• If there are no changes (i.e. no diff exists with the checked-out base branch), no pull request will be created and the action exits silently.

• If a pull request already exists and there are no further changes (i.e. no diff with the current pull request branch) then the action exits silently.

• If a pull request exists and new changes on the base branch make the pull request unnecessary (i.e. there is no longer a diff between the pull request branch and the base), the pull request is automatically closed. Additionally, if delete-branch is set to true the branch will be deleted.

Further workflows(Like Unit tests, Builds APK etc) on the generated PRs are disabled, we can enable them with the appropriate configuration if needed

[github-actions]

Unit Test Results

  44 files  +2    44 suites  +2   57s ⏱️ +15s
  87 tests +4    87 ✔️ +4  0 💤 ±0  0 ❌ ±0 
228 runs  +8  228 ✔️ +8  0 💤 ±0  0 ❌ ±0 

Results for commit 2b2f5be. ± Comparison against base commit 117fa71.

♻️ This comment has been updated with latest results.

[bmarty]

Thanks for the PR.

Can I ask you to remove the two lines referencing the 2 scripts in this file?

[bmarty]

Further workflows(Like Unit tests, Builds APK etc) on the generated PRs are disabled, we can enable them with the appropriate configuration if needed

Where is it disabled?

[ariskotsomitopoulos]

Further workflows(Like Unit tests, Builds APK etc) on the generated PRs are disabled, we can enable them with the appropriate configuration if needed

Where is it disabled?

It is disabled by default, it needs some modifications to support it, I can enhance the workflow to support it, do you think we need the tests on those PRs?

[ouchadam]

if these workflows create a PR, won't those PRs run the default set of tasks? https://github.com/vector-im/element-android/blob/develop/.github/workflows/tests.yml#L4 there's no filtering (from what I can tell!)

[ariskotsomitopoulos]

https://github.com/vector-im/element-android/blob/develop/.github/workflows/tests.yml#L4

I think they will not, they need special access for that (github access token), I asked @bmarty in the comment above if we want the tests to run in order to enhance the workflow!

[bmarty]

I agree with @ouchadam , every PRs should be checked by the regular CI. Looking at #4217, this is not the case, only Buildkite has been run... But this is probably fine for what the 2 tools are doing. Anyway we will still review the change before merging such PR

[bmarty]

Arg, there is a typo in the file name :/

[bmarty]

soruces

[ariskotsomitopoulos]

nice catch !

[bmarty]

Please rename the file to fix the typo and we can merge the PR.

Thanks!

[ariskotsomitopoulos]

I agree with @ouchadam , every PRs should be checked by the regular CI. Looking at #4217, this is not the case, only Buildkite has been run... But this is probably fine for what the 2 tools are doing. Anyway we will still review the change before merging such PR

I agree with both approaches! If we want all tests to run I can enhance it anytime, no worries

[bmarty]

Thanks for the PR.

Can I ask you to remove the two lines referencing the 2 scripts in this file?

It has been done directly on the develop branch IFAIU in d263409. It could have been part of this PR.

[ariskotsomitopoulos]

Thanks for the PR.
Can I ask you to remove the two lines referencing the 2 scripts in this file?

It has been done directly on the develop branch IFAIU in d263409. It could have been part of this PR.

You are totally right! It might be good to add a Branch Protection Rule to prevent this to happen again.