Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check IS privacy policy #4174

Closed
2 of 3 tasks
bmarty opened this issue Oct 6, 2021 · 7 comments
Closed
2 of 3 tasks

Check IS privacy policy #4174

bmarty opened this issue Oct 6, 2021 · 7 comments
Assignees

Comments

@bmarty
Copy link
Member

bmarty commented Oct 6, 2021

Originally posted by @deniseal in #2377 (comment)

Specific to vector.im identity server

https://vector.im/_matrix/identity/v2/terms returns:

{
  "policies": {
    "privacy_notice": {
      "version": "1",
      "en": {
        "name": "Privacy Notice",
        "url": "https://vector.im/identity-server-privacy-notice-1"
      }
    }
  }
}

This is not correct, the URL should be https://element.io/is-privacy-notice instead of https://vector.im/identity-server-privacy-notice-1, but a redirection exists though

  • Update the response from this URL on this server

Note: if we update the URL, the users will have to accept again the T&C because the agreement is stored in the account data, per URL. This is maybe why this URL has not been updated.

For every identity servers

Element Android already displays the policies when the user choose an identity server, but after that those policies are not displayed anymore. Even if the user disconnects and connects again to the same Identity Server, policies are not displayed anymore since the agreement is stored in the account data per URL.

  • Element Android should display the list of URLs in the discovery screen, In a new expandable section "Identity server policy", below the Identity server URL

image

  • A link "Policy" is added to the user consent dialog below as a neutral action (on the left). The link open the Discovery screen, with the policy section expanded.

image

@bmarty bmarty self-assigned this Oct 6, 2021
@bmarty bmarty changed the title Can we please ensure we are linking to the most up to date version of the IS privacy policy: this is the right document: https://element.io/is-privacy-notice Check IS privacy policy Oct 6, 2021
@bmarty bmarty added this to the Sprint - Element 1.3.2 milestone Oct 6, 2021
@ouchadam
Copy link
Contributor

ouchadam commented Oct 6, 2021

I couldn't find any expandable setting examples within the app but the room topic does use an expandable text view, is this what you meant?

ONCLICK VIA DIALOG
on-click dialog

@bmarty
Copy link
Member Author

bmarty commented Oct 7, 2021

I was thinking on doing something similar to https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/roomprofile/permissions/RoomPermissionsController.kt#L155

image

image

@bmarty
Copy link
Member Author

bmarty commented Oct 7, 2021

Also the dialog is also displayed at a second location (room member invite screen IIRC), it should also be able to open the Discovery screen

@bmarty
Copy link
Member Author

bmarty commented Oct 7, 2021

Also the T&C screen look like this:

image

Maybe we can get inspiration from the items in this list, reusing "Privacy Notice" wording from the identity sever response and put the url below.

@ouchadam
Copy link
Contributor

ouchadam commented Oct 7, 2021

something like this~

COLLAPSED EXPANDED DIALOG GIF
device-2021-10-07-102025 device-2021-10-07-102032 device-2021-10-07-102043 policies

to confirm, when tapping the item, what should happen?

  • nothing~
  • open a WebViewActivity
  • open a WebView dialog Context.displayInWebView
  • open the browser

@bmarty
Copy link
Member Author

bmarty commented Oct 7, 2021

to confirm, when tapping the item, what should happen?

Same as https://github.com/vector-im/element-android/blob/develop/vector/src/main/java/im/vector/app/features/terms/ReviewTermsFragment.kt#L114

@bmarty
Copy link
Member Author

bmarty commented Oct 8, 2021

2 latest point done in ea 1.3.2

@bmarty bmarty closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants