Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted Room previews aren't working #3946

Closed
daniellekirkwood opened this issue Sep 1, 2021 · 2 comments · Fixed by #3986
Closed

Restricted Room previews aren't working #3946

daniellekirkwood opened this issue Sep 1, 2021 · 2 comments · Fixed by #3986
Assignees
@BillCarsonFr
Labels
A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@daniellekirkwood
Copy link
Contributor

Steps to reproduce

  1. In Rooms list in Space
  2. Select Room that am not a member of (appears in Suggested list)
  3. Bottom sheet appears "This room can't be previewed"

What did you expect?

To see a preview of the room

What happened?

Bottom sheet appears "This room can't be previewed"
(Also, content should display room name, not Matrix ID; https://github.com/vector-im/element-android/issues/3940 )

Your phone model

No response

Operating system version

No response

Application version and app store

https://buildkite.com/organizations/matrix-dot-org/pipelines/element-android/builds/3224/jobs/a1fe572d-8a7b-4406-8a0f-37f4c9ff4787/artifacts/30990f61-8f7d-4dc6-af1e-340765110cc6

Homeserver

No response

Have you submitted a rageshake?

No
@daniellekirkwood daniellekirkwood added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 1, 2021
@BillCarsonFr
Copy link
Member

I think this probably due to this #3950
Could you retry with this build https://buildkite.com/organizations/matrix-dot-org/pipelines/element-android/builds/3239/jobs/473a0c3b-c914-408c-a5b9-b54425628648/artifacts/13269b0f-d6f1-460e-a9cd-3be0a27905dc

@BillCarsonFr BillCarsonFr self-assigned this Sep 7, 2021
@BillCarsonFr
Copy link
Member

It looks like I need to use https://github.com/deepbluev7/matrix-doc/blob/room-summaries/proposals/3266-room-summary.md in order to get a proper preview of the room

@BillCarsonFr BillCarsonFr changed the title Room previews aren't working Restricted Room previews aren't working Sep 8, 2021
@BillCarsonFr BillCarsonFr mentioned this issue Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better room preview, use room Summary API if available element-hq/element-android
2 participants
@BillCarsonFr @daniellekirkwood