Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save button for adding rooms to a space is hidden when scrolling through list of rooms #3935

Closed
kittykat opened this issue Sep 1, 2021 · 0 comments · Fixed by #4118
Closed

Save button for adding rooms to a space is hidden when scrolling through list of rooms #3935

kittykat opened this issue Sep 1, 2021 · 0 comments · Fixed by #4118
Assignees
@BillCarsonFr
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Spaces-Testing Testing for the Spaces release

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 1, 2021 •
edited
Loading

Steps to reproduce

  1. Left panel -> hamburger button -> "+ Add rooms"
  2. Scroll down
  3. Select some rooms

Screenshot_20210901-115845.png

What did you expect?

Be able to see "Save" or "Add" button at all times

What happened?

The Save button doesn't show until you select your first room so if you scroll before adding any room, then it isn't visible after ticking rooms.

Your phone model

n/a

Operating system version

n/a

Application version and app store

https://buildkite.com/organizations/matrix-dot-org/pipelines/element-android/builds/3224/jobs/a1fe572d-8a7b-4406-8a0f-37f4c9ff4787/artifacts/30990f61-8f7d-4dc6-af1e-340765110cc6

Homeserver

n/a

Have you submitted a rageshake?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 1, 2021
@kittykat kittykat added the Z-Spaces-Testing Testing for the Spaces release label Sep 20, 2021
@novocaine novocaine added the X-Needs-Design May require input from the design team label Sep 22, 2021
@BillCarsonFr BillCarsonFr self-assigned this Sep 28, 2021
@BillCarsonFr BillCarsonFr removed the X-Needs-Design May require input from the design team label Sep 29, 2021
@BillCarsonFr BillCarsonFr mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Spaces-Testing Testing for the Spaces release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix do not hide toolbar on scroll element-hq/element-android
3 participants
@kittykat @novocaine @BillCarsonFr