Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Account Settings > Notifications > Advanced Notifications on android causes discrepancies with web #3672

Closed
langleyd opened this issue Jul 14, 2021 · 0 comments · Fixed by #3681

Comments

@langleyd
Copy link
Member

langleyd commented Jul 14, 2021

Describe the bug

Changing between None, Silent and Noisey on android causes discrepancies with web client.
Causing the selection for the notification setting in question to appear in a unselected state on web and the push rule setting is then duplicated under a new section that appears on web as "Advanced notification settings"
The only settings affected appear to be:

  • Messages containing @room
  • Messages in group chats
  • Encrypted messages in group chats
  • Call Invitations
  • Messages in one-to-one chats

To Reproduce

Steps to reproduce the behavior:

  1. Go to Account Settings > Notifications > Advanced Notifications on Android
  2. Cycle between None, Silent and Noisy for each setting (may have to do a number of times)
  3. Go to Settings > Notification Settings on web/desktop client
  4. For the settings listed above the selection will sometimes disappear and the setting duplicated as described above and shown in the screenshot

Expected behavior

Push Rule Setting is not duplicated and radio buttons remain in a selected state

Screenshots

image

Additional context

  • I have seen some discrepancies in the requests that are send when cycling the settings on android with the web for both the enable endpoint and the actions end point. Closing this gap I think should fix the behaviour seen on web.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant