Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bca/room upgrade #3551

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Feature/bca/room upgrade #3551

merged 11 commits into from
Jul 8, 2021

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jun 24, 2021

Add support for room version capabilities and room upgrade.

SDK Changes

Introduces a new RoomVersionService (implemented by Room):

  • fun getRoomVersion(): String
  • fun upgradeToVersion(version: String): String
  • fun getRecommendedVersion() : String
  • fun userMayUpgradeRoom(userId: String): Boolean
  • fun isUsingUnstableRoomVersion(): Boolean

UI

Ugrade Room
Support /upgraderoom command. Will show a dialog bottomsheet with some options with proper progress report (for auto invite), and proper error handling

image

Join Replacement Room

Adds proper progress and error reporting when joining a replacement room.
Previously was done in background with a toaster on error. As joining can take long, a dialog will show up with progress and error

image

__ Detect unstable room version__

If the user can upgrade a room, in the settings a warning will be shown if the room is using an unstable room version with a button to upgrade

image

Tombstine item rendering update

Was missing some margins, and was inconsistent from replaced room to replacement room

image

Dev Tools

In developer mode, room version capabilities will be visible in HomeServer settings page
image

Fixes #3507

@BillCarsonFr BillCarsonFr requested a review from bmarty June 24, 2021 07:53
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've pushed 3 commits to fix some issues and cleanup the code.

@bmarty bmarty merged commit 2948f03 into develop Jul 8, 2021
@bmarty bmarty deleted the feature/bca/room_upgrade branch July 8, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing progress feedback when clicking on tombstone event
2 participants