Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'Jump to first unread message' feature in rooms using m.fully_read marker #328

Closed
MurzNN opened this issue Jul 11, 2019 · 8 comments
Assignees
Labels
X-Needs-Design May require input from the design team
Milestone

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Jul 11, 2019

Seems at now RiotX miss Jump to first unread message feature, that scroll room timeline to first unread message. This is very important feature for most of users, especially in rooms with many members. Also X action for mark all as read.

I can't find issue about implementing this feature, only about displaying read markers #84 in phase2. But displaying markers is not so important comparing to Jump to first unread message feature.

For implement jumping we can use m.fully_read marker from spec https://matrix.org/docs/spec/client_server/r0.4.0#fully-read-markers

So I suggest to implement Jump to first unread message earlier, than displaying read markers.

@bmarty bmarty added this to the Phase 2 milestone Jul 11, 2019
@MurzNN
Copy link
Contributor Author

MurzNN commented Jul 11, 2019

Ow, I look at wrong place https://github.com/vector-im/riotX-android/projects/1
Phase0 is finished, Phase1 is almost too: https://github.com/vector-im/riotX-android/milestones
So phase2 is good place, together with #84

@jtagcat
Copy link

jtagcat commented Jul 14, 2019

Note: some users prefer to jump to first, without losing their last read position (read few first unread, then jump back to their last position)

@jtagcat
Copy link

jtagcat commented Jul 15, 2019

Addition to ny comment: In discord I hate when I reply to someone, after sending the message, it automatically moves me to the bottom. RiotX already opens a new page what you can close with x, when you click jump to 1st.

@bmarty bmarty modified the milestones: Phase 2, sprint2 Jul 18, 2019
@bmarty bmarty modified the milestones: sprint2, phase3, sprint3 Aug 8, 2019
@bmarty bmarty added the X-Needs-Design May require input from the design team label Aug 20, 2019
@bmarty
Copy link
Member

bmarty commented Aug 20, 2019

Related to #84

@bmarty
Copy link
Member

bmarty commented Aug 29, 2019

-> next sprint

@bmarty bmarty modified the milestones: sprint3, sprint4 Aug 29, 2019
@bmarty
Copy link
Member

bmarty commented Oct 9, 2019

Implemented by #592

@progserega
Copy link

"Jump marker" some times freeze:

Video:
https://yadi.sk/i/qq-2DY3YCAAunQ

RiotX version: 0.7.0 G-b1099

@MurzNN
Copy link
Contributor Author

MurzNN commented Nov 26, 2019

Same problem for me with unmarkable as read messages sometimes. Workaround is scroll down to next messages (for hide problematic message from screen) and use "jump to unread"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Design May require input from the design team
Projects
None yet
Development

No branches or pull requests

5 participants