Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Composer Design Update #3182

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Apr 15, 2021

composer_empty
composer_with_text

@onurays onurays linked an issue Apr 16, 2021 that may be closed by this pull request
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The max height of the composer frame should be increased so it covers more UI real estate See an example here https://www.figma.com/file/uaWc62Ux2DkZC4OGtAGcNc/Voice-Messages?node-id=838%3A225

  • The keyboard icon inside the frame is too big. Could we reduce? The colour should also be changed so it reflects Figma's specs
    Screenshot_20210416-154955_Element dbg
    Example in Figma here.

  • When I am typing something and have just added an emoji, the keyboard should return automatically. If I happen to have added an emoji in the text frame without having pressed back on the keyboard button before sending, Once it is sent, the Keyboard icon remains in the text frame. See below
    Screenshot_20210416-155003_Element dbg

@TR-SLimey
Copy link
Contributor

@gaelledel I'm no designer, so feel free to disregard my comments, but I wanted to suggest:

  • Keeping the max composer height a bit smaller than that in Figma. Maybe 1/2 as opposed to 3/4. This is because, when replying to a lengthy message, with a long message of your own, it can be difficult to go back to and reference the message you're replying to. The timeline is above the composer, so it's also more difficult to scroll the timeline than the composer which giving the timeline a bit more space should improve.

  • Not automatically switching back from emoji keyboard after adding an emoji - sometimes one might wish to enter multiple emojis. However, the keyboard should still switch back upon sending.

WDYT?

@onurays onurays requested a review from gaelledel May 3, 2021 13:55
Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you for the changes. Just two minor things still and then all good to go

  • On dark mode the Reveal + buttons and X close should have other colours referenced here https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=1237%3A16664. The animation OnPress is missing but you might actually haven't done that part of the work yet though.

  • When typing and sending you actually see the composer frame expanding and there's a weird flash on the emoji icon. I wonder if we can tweak this?

@github-tomster
Copy link

as one clearly can see on @gaelledel's screenshots
it is still a mismatch between the emojis!
will this 'update' fix this mess?

@onurays onurays marked this pull request as ready for review June 8, 2021 09:58
bmarty and others added 3 commits June 9, 2021 17:35
Author: Onuray. Update colors by bmarty and squashed
@bmarty bmarty force-pushed the feature/ons/message_composer_ui branch from f9a3d0f to ea7e624 Compare June 9, 2021 15:52
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I updated to colors

@bmarty bmarty merged commit 5d69bc9 into develop Jun 9, 2021
@bmarty bmarty deleted the feature/ons/message_composer_ui branch June 9, 2021 16:26
@github-tomster
Copy link

@5d69bc9
was the inconsistent and wrong emoji display fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Message Composer design
5 participants