-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message Composer Design Update #3182
Conversation
onurays
commented
Apr 15, 2021
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The max height of the composer frame should be increased so it covers more UI real estate See an example here https://www.figma.com/file/uaWc62Ux2DkZC4OGtAGcNc/Voice-Messages?node-id=838%3A225
-
The keyboard icon inside the frame is too big. Could we reduce? The colour should also be changed so it reflects Figma's specs
Example in Figma here. -
When I am typing something and have just added an emoji, the keyboard should return automatically. If I happen to have added an emoji in the text frame without having pressed back on the keyboard button before sending, Once it is sent, the Keyboard icon remains in the text frame. See below
@gaelledel I'm no designer, so feel free to disregard my comments, but I wanted to suggest:
WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thank you for the changes. Just two minor things still and then all good to go
-
On dark mode the Reveal + buttons and X close should have other colours referenced here https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=1237%3A16664. The animation OnPress is missing but you might actually haven't done that part of the work yet though.
-
When typing and sending you actually see the composer frame expanding and there's a weird flash on the emoji icon. I wonder if we can tweak this?
as one clearly can see on @gaelledel's screenshots |
Author: Onuray. Update colors by bmarty and squashed
f9a3d0f
to
ea7e624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I updated to colors
@5d69bc9 |