Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs_url and is_url not respected #2684

Closed
ManDay opened this issue Jan 16, 2021 · 7 comments · Fixed by #4335
Closed

hs_url and is_url not respected #2684

ManDay opened this issue Jan 16, 2021 · 7 comments · Fixed by #4335
Assignees
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Product Issue needs input from Product team Z-FTUE Issue is relevant to the first time use project or experience

Comments

@ManDay
Copy link

ManDay commented Jan 16, 2021

I am trying to reenact the FTUE for someone with little technical experience and encountered a problem that the https://mobile.element.io/?hs_url=…&is_url=… which is linked to by, for instance, https://chat.mozilla.org seems to have no effect (on the buildkite build), after a new install of the app. It just opens Element in the exact same configuration as if you had started it normally. Even navigating to the third option "Other - Custom & advanced settings" makes no mention of the URLs.

@pReya
Copy link

pReya commented Feb 6, 2021

See element-hq/element-web#5469

@Half-Shot
Copy link
Member

Half-Shot commented Oct 25, 2021

The title of this issue isn't the most useful, essentially this is "mobile.element.io links are no longer autoconfiguring Element (Android)".

@bmarty
Copy link
Member

bmarty commented Oct 25, 2021

This should work, I add it to our backlog

@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience labels Oct 25, 2021
@bmarty bmarty added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist X-Needs-Product Issue needs input from Product team labels Oct 25, 2021
@bmarty
Copy link
Member

bmarty commented Oct 25, 2021

The URI parameters are well parsed, but the app does not do anything with it. There is a TODO about it. I will need some design/product input to see what we will display to the user in such case, maybe skip this screen if and only if the homeserver URL is valid?

image

@rxl881
Copy link

rxl881 commented Oct 25, 2021

Cool. Thanks @bmarty -- Great to hear that the settings are already parsed. As you suggest, I think that the simplest solution is probably to skip that screen if the hs_url is set (or even if it's set to one.ems.host, if the more general option causes an issue for any reason).

@daniellekirkwood does that work from your point of view?

Hopefully we can get a 👍 on that quickly and prioritise this for a dedicated release asap? However, please let me know if there's any concern, or if anything needs to be discussed further. Cheers! 🙏

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Oct 25, 2021

Yes. If we have the information we need in order to skip this screen, and remove user confusion, let's do it.

Thanks

@bmarty
Copy link
Member

bmarty commented Oct 28, 2021

Done in Element Android 1.3.6

@bmarty bmarty closed this as completed Oct 28, 2021
@daniellekirkwood daniellekirkwood added Z-FTUE Issue is relevant to the first time use project or experience and removed Z-FTUE Issue is relevant to the first time use project or experience labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Product Issue needs input from Product team Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
6 participants