store cache for WidgetWebView between loads #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any specific issues with this pull request or is it just a low priority? I'll just close it if there are concerns with other widgets or something. |
|
Thanks for the PR. To be honest, I'm not sure about the impact with other widget, or even with the sticker widget. |
|
This would fix #2066 if merged. |
|
Done in 8a38f1c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sticker widget is extremely inefficient due to these lines, reloading every asset on the page any time the sticker widget is opened. I made a new sticker widget and made this change on my personal builds to avoid ten second load times every time I wanted to send a sticker. This should only cause issues for widgets hosted on servers that don't properly invalidate caches as far as I can tell, but the WebView cache can also be manually reset with the
Reset Cacheoption in the app settings.